Skip to content

Scenario not run in the Github CI#7117

Open
nccatoni wants to merge 4 commits into
mainfrom
nccatoni/fix-trace-stats-computation-client-drop-p0s-false
Open

Scenario not run in the Github CI#7117
nccatoni wants to merge 4 commits into
mainfrom
nccatoni/fix-trace-stats-computation-client-drop-p0s-false

Conversation

@nccatoni

@nccatoni nccatoni commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The gitlab CI implementation surfarced a scenario that is not run in the GitHub CI. This PR adds it.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@nccatoni nccatoni requested a review from cbeauchesne June 9, 2026 09:51
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core
tests/schemas/test_schemas.py                                           @DataDog/system-tests-core

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jun 9, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 5 Pipeline jobs failed

Testing the test | System Tests (cpp_httpd, dev) / End-to-end #2 / httpd 2   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.stats.test_stats.Test_Client_Drop_P0s.test_client_drop_p0s_false[httpd] from system_tests_suite   View in Datadog (Fix with Cursor)
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Client_Drop_P0s object at 0x7fad04511a60>

    def test_client_drop_p0s_false(self):
        """Test that when agent reports client_drop_p0s=false, tracer does not report computing stats."""
    
        # Verify the agent is configured to report client_drop_p0s as false
E       assert 0 > 0
...

Testing the test | System Tests (cpp_httpd, prod) / End-to-end #2 / httpd 2   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.stats.test_stats.Test_Client_Drop_P0s.test_client_drop_p0s_false[httpd] from system_tests_suite   View in Datadog (Fix with Cursor)
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Client_Drop_P0s object at 0x7f61ce757500>

    def test_client_drop_p0s_false(self):
        """Test that when agent reports client_drop_p0s=false, tracer does not report computing stats."""
    
        # Verify the agent is configured to report client_drop_p0s as false
E       assert 0 > 0
...

Testing the test | System Tests (cpp_nginx, dev) / End-to-end #2 / nginx 2   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.stats.test_stats.Test_Client_Drop_P0s.test_client_drop_p0s_false[nginx] from system_tests_suite   View in Datadog (Fix with Cursor)
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Client_Drop_P0s object at 0x7fee2b47da90>

    def test_client_drop_p0s_false(self):
        """Test that when agent reports client_drop_p0s=false, tracer does not report computing stats."""
    
        # Verify the agent is configured to report client_drop_p0s as false
E       assert 0 > 0
...

View all 5 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 81b7d32 | Docs | Datadog PR Page | Give us feedback!

@nccatoni nccatoni marked this pull request as ready for review June 9, 2026 11:36
@nccatoni nccatoni requested a review from a team as a code owner June 9, 2026 11:36
@nccatoni nccatoni changed the title Nccatoni/fix trace stats computation client drop p0s false Scenario not run in the Github CI Jun 10, 2026
@nccatoni nccatoni enabled auto-merge (squash) June 11, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants